Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] batchify.Pad() padding value warning #747

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

szha
Copy link
Member

@szha szha commented Jun 3, 2019

Description

padding value warning for batchify.Pad() if padding_value is 0. resolves #679

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • padding value warning for batchify.Pad() if padding_value is 0.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request head (pad_warn@1918771). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #747 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage    90.5%   90.49%   -0.02%     
==========================================
  Files          65       65              
  Lines        6076     6078       +2     
==========================================
+ Hits         5499     5500       +1     
- Misses        577      578       +1
Impacted Files Coverage Δ
src/gluonnlp/data/batchify/batchify.py 96.29% <100%> (+0.09%) ⬆️
src/gluonnlp/data/dataloader.py 83.62% <0%> (-0.87%) ⬇️

@mli
Copy link
Member

mli commented Jun 3, 2019

Job PR-747/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-747/1/index.html

@szha szha merged commit d02f396 into dmlc:master Jun 5, 2019
@szha szha deleted the pad_warn branch June 5, 2019 04:17
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[usability] print warnings when Pad() is used
3 participants