Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Pytest 4 support #728

Merged
merged 1 commit into from
May 24, 2019
Merged

Pytest 4 support #728

merged 1 commit into from
May 24, 2019

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 24, 2019

Should fix pytest > 4 support. See #727

@leezu leezu requested a review from szha as a code owner May 24, 2019 15:25
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fixesforpytest4@65a375e). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented May 24, 2019 •
edited
Loading

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files          65       65           
  Lines        6071     6071           
=======================================
  Hits         5498     5498           
  Misses        573      573

@leezu leezu changed the title Description ## Pytest 4 support May 24, 2019
szha
szha reviewed May 24, 2019
View reviewed changes
setup.py Show resolved Hide resolved
@szha
Copy link
Member

szha commented May 24, 2019

Thanks. I was thinking of using tests_require but since we're not testing through setup.py by using test_suite I think it's fine.

@mli
Copy link
Member

mli commented May 24, 2019

Job PR-728/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-728/1/index.html

@leezu leezu merged commit 01727fc into dmlc:master May 24, 2019
@leezu leezu deleted the fixesforpytest4 branch May 24, 2019 18:19
@leezu leezu mentioned this pull request May 24, 2019
Closed
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
@leezu
Fix test infrastructure for pytest > 4 and bump CI pytest version (dm…
70b47d0 
…lc#728)

Issues were caused by
https://docs.pytest.org/en/latest/historical-notes.html#marker-revamp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leezu @szha @mli @eric-haibin-lin