Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Enhancement] run evaluation periodically for BERT pre-training #720

Merged
merged 1 commit into from
May 23, 2019

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented May 22, 2019

Description

As title.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

❗ No coverage uploaded for pull request head (dev-acc@367681f). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #720 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #720     +/-   ##
=========================================
+ Coverage   90.53%   90.63%   +0.1%     
=========================================
  Files          65       65             
  Lines        5991     5991             
=========================================
+ Hits         5424     5430      +6     
+ Misses        567      561      -6
Impacted Files Coverage Δ
src/gluonnlp/data/dataloader.py 88.79% <0%> (+5.17%) ⬆️

@mli
Copy link
Member

mli commented May 23, 2019

Job PR-720/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-720/1/index.html

@eric-haibin-lin eric-haibin-lin merged commit 8fe3f31 into dmlc:master May 23, 2019
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
@eric-haibin-lin eric-haibin-lin deleted the dev-acc branch February 2, 2020 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants