Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[reorg] Move ICSL script out of BERT folder #1131

Merged
merged 7 commits into from
Feb 2, 2020

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jan 31, 2020

Description

A step further to make the bert folder thinner. Also add test for the script.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner January 31, 2020 06:31
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #1131 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   87.76%   88.32%   +0.55%     
==========================================
  Files          67       67              
  Lines        6310     6310              
==========================================
+ Hits         5538     5573      +35     
+ Misses        772      737      -35
Impacted Files Coverage Δ
src/gluonnlp/model/attention_cell.py 92.17% <0%> (+1.67%) ⬆️
src/gluonnlp/model/transformer.py 91.66% <0%> (+4.48%) ⬆️
src/gluonnlp/model/utils.py 77.69% <0%> (+6.92%) ⬆️
src/gluonnlp/model/seq2seq_encoder_decoder.py 80% <0%> (+30%) ⬆️

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/1/index.html

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/3/index.html

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/2/index.html

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/4/index.html

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/5/index.html

@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1131/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1131/6/index.html

@eric-haibin-lin eric-haibin-lin merged commit 8f475df into dmlc:master Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants