Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] Fix Language Modeling index.rst #1100

Merged
merged 1 commit into from
Jan 7, 2020
Merged

[DOC] Fix Language Modeling index.rst #1100

merged 1 commit into from
Jan 7, 2020

Conversation

szhengac
Copy link
Member

@szhengac szhengac commented Jan 7, 2020

Description

Training cmd of AWD-LSTM is not consistent with log.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szhengac szhengac requested a review from a team as a code owner January 7, 2020 06:43
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          67       67           
  Lines        6266     6266           
=======================================
  Hits         5534     5534           
  Misses        732      732

@mli
Copy link
Member

mli commented Jan 7, 2020

Job PR-1100/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1100/1/index.html

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interval can be calculated from the log by looking at the gap between test loss and Learning rate after interval update lines.

@leezu leezu merged commit 1c8decd into dmlc:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants