Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] update mxnet version in installation doc #1072

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Dec 19, 2019

Description

The doc is wrong. Updated to 1.6.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner December 19, 2019 19:47
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #1072 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage    88.3%   88.32%   +0.02%     
==========================================
  Files          67       67              
  Lines        6266     6263       -3     
==========================================
- Hits         5533     5532       -1     
+ Misses        733      731       -2
Impacted Files Coverage Δ
src/gluonnlp/utils/parameter.py 83.92% <ø> (+2.57%) ⬆️

@mli
Copy link
Member

mli commented Dec 19, 2019

Job PR-1072/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1072/2/index.html

@eric-haibin-lin eric-haibin-lin merged commit 4e6c42d into dmlc:master Dec 19, 2019
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: No matching distribution found for mxnet>=1.6.0

@szha let's update this with the html side for pre-releases once it's ready.

gongel pushed a commit to gongel/gluon-nlp that referenced this pull request Dec 20, 2019
[DOC] update mxnet version in installation doc (dmlc#1072)
@szha
Copy link
Member

szha commented Dec 20, 2019

I think this only applies to the doc for master branch, which is updated automatically.

@leezu
Copy link
Contributor

leezu commented Dec 20, 2019

@szha yes, but it's currently broken even for the master branch. So the command should be fixed once the html page listing mxnet pre-releases for pip is ready.

@eric-haibin-lin
Copy link
Member Author

That's reasonable. i bought up that we should publish the nightly build links to mxnet website on the dev list. But they are not yet available there. Then we can add a link on the gluonnlp master branch to all nightly builds.

@eric-haibin-lin eric-haibin-lin deleted the install-dco branch February 2, 2020 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants