Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[BUGFIX] unicode comma fix #1056

Merged
merged 1 commit into from
Dec 17, 2019
Merged

[BUGFIX] unicode comma fix #1056

merged 1 commit into from
Dec 17, 2019

Conversation

liuzh47
Copy link
Contributor

@liuzh47 liuzh47 commented Dec 16, 2019

Description

There is a unicode comma in the print statement. It needed to be replaced with an ASCII comma.

Fixes #1055

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

cc @dmlc/gluon-nlp-team

@liuzh47 liuzh47 requested a review from a team as a code owner December 16, 2019 10:29
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1056 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1056   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          67       67           
  Lines        6252     6252           
=======================================
  Hits         5519     5519           
  Misses        733      733

@mli
Copy link
Member

mli commented Dec 16, 2019

Job PR-1056/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1056/1/index.html

@leezu
Copy link
Contributor

leezu commented Dec 17, 2019

CI will fail until #1058 as the mxnet version used prior to #1058 suffers from apache/mxnet#16193

@mli
Copy link
Member

mli commented Dec 17, 2019

Job PR-1056/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1056/2/index.html

@leezu leezu merged commit 938837a into dmlc:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode comma error
4 participants