Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[CI] Remove skip_master feature #1017

Merged
merged 1 commit into from
Nov 24, 2019
Merged

[CI] Remove skip_master feature #1017

merged 1 commit into from
Nov 24, 2019

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 20, 2019

Description

Revert #685
We are currently only running tests with the master version of MXNet.

Propose to remove this feature, as it is dangerous to disable tests with the skip_master, as we may forget to enable them again. Instead, we can add a conditional skip based on the current date and an estimate when the issue is fixed in MXNet master.

cc @szha

@leezu leezu requested a review from szha November 20, 2019 04:32
@leezu leezu requested a review from a team as a code owner November 20, 2019 04:32
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #1017 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   89.93%   90.52%   +0.58%     
==========================================
  Files          67       67              
  Lines        6340     6340              
==========================================
+ Hits         5702     5739      +37     
+ Misses        638      601      -37
Impacted Files Coverage Δ
src/gluonnlp/model/bert.py 88.16% <0%> (-4.09%) ⬇️
src/gluonnlp/utils/files.py 45.09% <0%> (-3.93%) ⬇️
src/gluonnlp/model/sequence_sampler.py 91.63% <0%> (+17.07%) ⬆️

@mli
Copy link
Member

mli commented Nov 20, 2019

Job PR-1017/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1017/2/index.html

@leezu leezu merged commit 39a3f34 into dmlc:master Nov 24, 2019
@leezu leezu deleted the disableskipmaster branch November 24, 2019 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants