This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Make atomic functions return scope, not ref return #3541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #3480 by adding just
return
withoutscope
. That would suggestref T val
would return aT*
like&val
, but they return aT
. This trips upSharedRegion
in std.allocator after applying dlang/dmd#12812 because of this:localCurrent = atomicLoad(this._current);
Which would needlessly turn
localCurrent
into ascope
pointer sinceatomicLoad
's signature suggests it's essentially returning&this
which it isn't.