new commands format #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation on #2
This patch is mainly just a separation point between the old cmdslib (command line+API) parameter format and a proposed new one.
ipfs mountdoes the same as is (mounting paths set in the config)But takes variable arguments instead of flags now:
ipfs mount /fuse/ipfs/path/mnt/ipfs /fuse/ipns/path/mnt/ipns ...ipfs daemon --mountdoes the same as above, but requires vector flags instead of arguments.ipfs daemon --mount-path=/fuse/ipfs/path/mnt/ipfs --mount-path=/fuse/ipns/path/mnt/ipnsIn both instances, if the request comes from a terminal, it will render the text accordingly:
We retain the existing mount implementation for now, but are preparing to swap the node's instance manager (
ipfs.Mounts) with a new one that will handle requests of these format.Along with a new Fuse backend that fulfills these requests.