Next release planning

[djc]

@vallentin I forget what things I still wanted to resolve before releasing... Do you have anything else you would like to land in the short term?

[vallentin]

Here's a few from my TODO.md:

• {{ None }} produces self.None (Fixed in Fixed path parser to account for single identifier type names #453)
• {{ Some("foo") }} produces (self.Some)("foo") (Fixed in Fixed path parser to account for single identifier type names #453)
• {% let (x) = (2) %} produces let (x) = (2);, which is semantically wrong and should be let (x,) = (2);
  • Edit: This has previously been fixed
• .zip(0..5) produces .zip(&0..5) instead of .zip(0..5) (Fixed in Removed needless borrow of range #452)
• When fixing Removed needless borrow of range #452, I encountered that Askama cannot parse {% for ((i, j), k) in (0..10).zip(10..20).zip(20..30) %}, specifically the for loop pattern ((i, j), k)

Then of course also doing the ones from #427, that we agreed on. Though overall I just wanna iron out the bugs.

Been a bit busy for the past month, but I think I'll be able to fix those bugs in the upcoming weekend.

[djc]

Sounds good -- let's see where we are on Monday.

[vallentin]

One of them was already fixed, but I've fixed the 3 other bugs.

I also discovered an additional bug (I've edited the previous comment).

[djc]

I think it's past time we got this out. @vallentin when would you have time to investigate #494?

[vallentin]

If it can wait until Thursday / the weekend, then yes :)

[djc]

Yeah, that should be fine.

[djc]

I'll see if I can spend some time on this tomorrow (mostly writing up a change log).

[vallentin]

Was #494 the "last" important bug, before the new release? Just glancing through this issue and #427, then it seems the remaining stuff is new features.

When you start writing the change log, feel free to make a draft PR, then I'll comment any missing stuff I recall. I guess one of the most important things, is highlighting the change to the implicit borrowing. Mentioning that literal primitives and the result of functions are no longer borrowed.

[djc]

At this point I'll probably wait for the nom 7 release, which should help with the silly dependencies.

rust-bakery/nom#1323 (comment)

[kristoff3r]

Since nom 7 has been released, is there anything else blocking a release?

[djc]

I need to review/decide on #517 and #518 and then I need to write some release notes.

[djc]

I wrote up draft release notes: https://github.com/djc/askama/releases/edit/untagged-1f87fb7743ec53e520b9. @vallentin and @Kijewski, would you please review to see if anything important is missing or should be highlighted more?

[vallentin]

Maybe the "General changes" should be split up, so e.g. bug fixes are moved to the bottom of the description, e.g. #394 most probably haven't encountered this. Then "General changes" could be easier to glance through, so users can more easily spot the "real" changes, that affect them or they're interested about

[Kijewski]

A project this big can never be free of errors, that will only show themselves after the release. I think the changelog addresses to the users' interests quite well. 👍 from me!

[djc]

I've published updates for askama_escape, askama_shared, askama, askama_derive, askama_warp, askama_tide and askama_gotham. askama_axum depends on #583; askama_actix and askama_rocket depend on #584. That leaves askama_mendes.