PWA startup for linux with >1 chrome profile (#40) #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #40
I had to change
get-app-id-
* functions to return[app-id profile]
instead of justapp-id
, because the profile name (such asProfile 1
,Profile 2
,Default
) must be passed as--profile-directory
togoogle-chrome
binary when running the PWA version.In my case, following values are returned:
I have no idea how osx handles profiles, so I didn't touch the osx code and
nil
is returned as profile. That results in--profile-directory
flag not being added. Hope I didn't break anything here.