Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA startup for linux with >1 chrome profile (#40) #41

Merged

Conversation

brdloush
Copy link
Contributor

Possible fix for #40

I had to change get-app-id-* functions to return [app-id profile] instead of just app-id, because the profile name (such as Profile 1, Profile 2, Default) must be passed as --profile-directory to google-chrome binary when running the PWA version.

In my case, following values are returned:

(get-app-id-profile "portal")
;; => ["gbilcjcjkenedpcbagempggobciaddcp" "Profile 1"]

I have no idea how osx handles profiles, so I didn't touch the osx code and nil is returned as profile. That results in --profile-directory flag not being added. Hope I didn't break anything here.

Copy link
Owner

@djblue djblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @brdloush! It looks good, just have a few small comments. Should be good to merge after.

src/portal/runtime/jvm/launcher.clj Outdated Show resolved Hide resolved
src/portal/runtime/jvm/launcher.clj Outdated Show resolved Hide resolved
src/portal/runtime/jvm/launcher.clj Outdated Show resolved Hide resolved
@brdloush brdloush marked this pull request as ready for review January 23, 2021 02:03
@djblue djblue merged commit 2ea6190 into djblue:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants