Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Translations update #32871

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Update Translations update #32871

merged 1 commit into from
Apr 24, 2023

Conversation

minhaminha
Copy link
Contributor

Technical Summary

Upgrades the tibdex/github-app-token version used to get around an old issue. Also updates the body of the PR so it no longer instructs the user to close and open the PR (the tests will now run automatically).

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@minhaminha minhaminha added the product/invisible Change has no end-user visible impact label Apr 21, 2023
@minhaminha minhaminha merged commit 8cd7207 into master Apr 24, 2023
@minhaminha minhaminha deleted the ml/upgrade-github-app-token-version branch April 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

@orangejenny orangejenny Awaiting requested review from orangejenny orangejenny is a code owner

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhaminha @millerdev