Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vellum:b8e74d2c3ce5de0961042844f1827a325e5370c3 updates CKEditor to 4.21.0 #32861

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

ajeety4
Copy link
Contributor

@ajeety4 ajeety4 commented Apr 21, 2023

updates CkEditor to 4.21.0
[ci skip]

Product Description

See Upstream Vellum PR: dimagi/Vellum#1081

Technical Summary

https://dimagi-dev.atlassian.net/browse/INDIV-88

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

QA was passed on staging.
https://dimagi-dev.atlassian.net/browse/QA-4973

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@ajeety4 ajeety4 added QA Passed product/invisible Change has no end-user visible impact labels Apr 21, 2023
@ajeety4 ajeety4 requested a review from millerdev April 21, 2023 07:39
@millerdev
Copy link
Contributor

Closing and opening to run tests.

@millerdev millerdev closed this Apr 21, 2023
@millerdev millerdev reopened this Apr 21, 2023
Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more churn in manifest.txt than I would expect. Maybe that's a side-effect of upgrading CKEditor or maybe a bunch of other dependencies were updated in addition? In any case since this passed QA it's probably not a problem.

Edit: I don't understand why github is not running tests.

@ajeety4
Copy link
Contributor Author

ajeety4 commented Apr 24, 2023

There's more churn in manifest.txt than I would expect. Maybe that's a side-effect of upgrading CKEditor or maybe a bunch of other dependencies were updated in addition? In any case since this passed QA it's probably not a problem.

Edit: I don't understand why github is not running tests.

For manifest.text churn, not anything specific to CKEditor, however this does include some dependency updates on Vellum since last merge.
dimagi/Vellum@a68c0b7 and dimagi/Vellum@52333e9 contains most of them.

@ajeety4
Copy link
Contributor Author

ajeety4 commented Apr 24, 2023

Closing and reopening again to run tests.
Edit: Still not working, trying amend and force push with no changes!
Edit2: Trying again with updating this branch with master.

@ajeety4 ajeety4 closed this Apr 24, 2023
@ajeety4 ajeety4 reopened this Apr 24, 2023
updates CkEditor to 4.21.0
[ci skip]
@ajeety4 ajeety4 merged commit af3d2ae into master Apr 24, 2023
@ajeety4 ajeety4 deleted the aj/update-cke-editor branch April 24, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact QA Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants