Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu version to 22.04 in Github workflow for tests #1082

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

ajeety4
Copy link
Contributor

@ajeety4 ajeety4 commented Apr 6, 2023

Summary

Quick PR to update the ubuntu image to 22.04 in workflow for tests as 18.04 was deprecated from 4th April 2023.
Also bumps dev dependency mocha-headless chrome to 4.0.0 as after updaing the ubuntu version, tests won't run and gave this error.

Note: Did not spend much time investigating the error as updating the dependency resolved it. Noticed that the current puppeter version was quite outdated.

Product Description

Safety Assurance

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

QA Plan

Safety story

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@ajeety4 ajeety4 added the dependencies Pull requests that update a dependency file label Apr 6, 2023
@ajeety4 ajeety4 requested review from biyeun and millerdev April 6, 2023 09:50
@ajeety4 ajeety4 merged commit d2bdae0 into master Apr 6, 2023
@ajeety4 ajeety4 deleted the aj/update-ubuntu-version-workflow branch April 6, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants