Upgrade http-server from 0.12.3 to 14.1.0
#1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switches to approximate versioning - removes (discontinued) `ecstatic` dependency - removes `colors` dependency
joxl
added
product/invisible
dependencies
joxl
requested review from
dannyroberts,
millerdev,
biyeun,
AmitPhulera and
gherceg
millerdev
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jira: SAAS-12229
Upgrade
http-serverto latest release (14.1.0) to removeecstatic(discontinued) dependency.ecstaticdependencycolorsdependencyReviewed release history and looks safe. Most notable breaking change is drop of support for Node.js 10.
Safety Assurance
Automated test coverage
No tests (only used via the
testserverscript).QA Plan
No QA.
Safety story
Library is only used via package scripts (testserver) and is only invoked in the most basic way (not heavily configured). New version works fine out of the box and upgrade is safe.
Rollback instructions