Define Haiku assets path #7498
Closed
Define Haiku assets path #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably you ended up changing the line ending, what browser? |
|
Falkon (aka Qupzilla), unfortunately browser choice is still pretty limited here :/ |
|
it might be submitting forms with Unix line ending but the HTML standard calls for Windows style line endings afaik. this probably isnt an issue on most projects but our files also use windows style line endings |
|
Alright, yeah, I can see that being an issue. Should I act on it and redo the changes from a different environment? |
|
ill fix it later |
AJenbo
reviewed
Oct 23, 2024
|
Move it after the if clause to allow for the path to still be manually overwritten using arguments. It's merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, some time ago I toyed with building the 1.5.3 DevilutionX release for Haiku OS, the binary + needed assets compiled without issues out of the box but due to some peculiarities of Haiku's build system the assets path has to be tweaked. I'm sparing you the details, I'll just say even if using a directory variable named "B_SYSTEM_DATA_DIRECTORY" might sound bad, it's totally normal due to the way the files are packaged for this OS.
Committing this as DevilutionX runs flawlessly on the OS (besides missing the needed libraries to enable ZeroTier) :)
EDIT: I only added about 10 lines via web interface (10-13 and 121-126) but the git diff shows the entire file as changed, I don't know what's up with that