Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize StartSpell() #7211

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Optimize StartSpell() #7211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Source/player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ void StartSpell(Player &player, Direction d, WorldTileCoord cx, WorldTileCoord c
}

// Checks conditions for spell again, because initial check was done when spell was queued and the parameters could be changed meanwhile
bool isValid = true;
bool isValid = false;
switch (player.queuedSpell.spellType) {
case SpellType::Skill:
case SpellType::Spell:
Expand All @@ -265,8 +265,7 @@ void StartSpell(Player &player, Direction d, WorldTileCoord cx, WorldTileCoord c
case SpellType::Charges:
isValid = CanUseStaff(player, player.queuedSpell.spellId);
break;
case SpellType::Invalid:
isValid = false;
default:
break;
}
if (!isValid)
Expand Down
Loading