Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 0 charge staff in speed spell #6502

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix 0 charge staff in speed spell #6502

merged 3 commits into from
Sep 23, 2024

Conversation

kphoenix137
Copy link
Collaborator

Fixes #6149

@FitzRoyX
Copy link

I don't understand the inconsistency. A staff can be recharged, a scroll can't. 0 charges is equivalent to a lvl 0 spell that you've learned but you just can't cast anymore.

@StephenCWills
Copy link
Member

Qndel described it pretty succinctly in the issue. The spell icon shows up after Save/Load. It doesn't show up if you don't Save/Load.

@kphoenix137
Copy link
Collaborator Author

I don't understand the inconsistency. A staff can be recharged, a scroll can't. 0 charges is equivalent to a lvl 0 spell that you've learned but you just can't cast anymore.

Desktop.2023.08.25.-.14.17.57.05.mp4

@kphoenix137 kphoenix137 requested a review from AJenbo March 8, 2024 03:55
@qndel qndel merged commit 793eb7a into diasurgical:master Sep 23, 2024
23 checks passed
@kphoenix137 kphoenix137 deleted the fix-0-charge-speed-spell branch September 23, 2024 18:39
@AJenbo
Copy link
Member

AJenbo commented Sep 23, 2024

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qndel qndel qndel approved these changes

@AJenbo AJenbo Awaiting requested review from AJenbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in treating 0 charge staff
5 participants
@kphoenix137 @FitzRoyX @StephenCWills @AJenbo @qndel