Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pytorch / tensorflow for default install of DIANNA #510

Closed
stefsmeets opened this issue Mar 14, 2023 · 2 comments · Fixed by #538
Closed

Remove dependency on pytorch / tensorflow for default install of DIANNA #510

stefsmeets opened this issue Mar 14, 2023 · 2 comments · Fixed by #538
Assignees

Comments

@stefsmeets
Copy link
Contributor

The default dianna install is quite large because of dependencies on tensorflow and pytorch. These dependencies are not necessary to run dianna. But it makes it very slow to install and the virtualenvironment is very large (6-7 GB).

It will improve the user experience if the default install of dianna is quite lean.

We could separate the dependencies where necessary in subpackages:

pip install dianna
pip install dianna[dashboard]
pip install dianna[tutorials]
...
@stefsmeets
Copy link
Contributor Author

I removed torch / tensorflow from the default install. It makes it really clear what the difference in install size is.

My venv before installing torchtext:

(.venv) stef@debian:~/python/dianna $ du -hd0 .venv
779M	.venv

My venv after installing torchtext:

(.venv) stef@debian:~/python/dianna $ du -hd0 .venv
5.0G	.venv

@stefsmeets
Copy link
Contributor Author

stefsmeets commented Mar 28, 2023

onnx_tf requires tensorflow and tensorflow_probabilities, but it does not declare them as dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant