Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome crashes when opening applications-tab #3698

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: chrome crashes when opening applications-tab #3698

merged 2 commits into from
Jul 3, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

Summary:

  • For the last month, google chrome has been crashing every time you try to open devtools/application.
  • This was because we had an undiscovered error in our manifest.json file
  • Changed icon type to image/x-icon

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner June 30, 2024 13:11
@eirikhaugstulen eirikhaugstulen changed the title fix: Chrome crashes when opening applications-tab fix: chrome crashes when opening applications-tab Jun 30, 2024
@eirikhaugstulen
Copy link
Contributor Author

This won't solve all problems, as we also need the generated .d2/public/manifest.json file to adhere to the specs, but this is what's needed from the capture app I believe.

simonadomnisoru
simonadomnisoru approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works in my localhost

@eirikhaugstulen eirikhaugstulen merged commit da2fa7b into master Jul 3, 2024
24 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/app-breaks-when-opening-devtools branch July 3, 2024 14:35
dhis2-bot added a commit that referenced this pull request Jul 3, 2024
@dhis2-bot
chore(release): cut 100.70.4 [skip release]
f71a16f 
## [100.70.4](v100.70.3...v100.70.4) (2024-07-03)

### Bug Fixes

* chrome crashes when opening applications-tab ([#3698](#3698)) ([da2fa7b](da2fa7b))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.70.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

@JoakimSM JoakimSM JoakimSM approved these changes

Assignees
No one assigned
Labels
released skip-e2e-tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @JoakimSM