Make posting list memory rollup happen right after disk #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…routine. This ensures that we don't see as many minTs errors. And that we don't end up in weird race conditions which might cause a txn to be lost.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
- Do not rollup posting lists right after commits, because it causes some strange race conditions which can cause a state mismatch between memory and disk. - For the PLs in LRU cache, roll them up right after doing a successful roll-up on disk. - Modify Rollup function to take a `readTs`, which can be set to the roll-up read ts. * Do the memory rollup right after the disk rollup in the background goroutine. This ensures that we don't see as many minTs errors. And that we don't end up in weird race conditions which might cause a txn to be lost. * Fix up some asserts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readTs, which can be set to the roll up read ts.This change is