-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance improvements #173
Comments
can this be improved? i autosave every 500ms (in case that has an effect) |
Does this still happen when autosave is turned off? This looks like a bug with the type checking debounce logic (rather than purely a performance issue), so it'll be helpful to know whether this is related to autosaving. |
I have this issue too and autosave is turned off, not sure if it could be caused by wsl2. |
turning off autosave didn't help :/ |
Thanks for checking. Are there any public projects which I could use to fully recreate the issue on my end? For some context, large projects with > 100 files used to take over a minute to fully type-check (comparable to large Rust projects in VS Code). Something on the order of 1-2 seconds is currently expected for projects with large numbers of files and dependencies. This can be further improved in the future, and hopefully the recent round of optimizations makes the extension a lot more usable for large projects in the immediate term. |
Yes, you can check this |
Thanks! I will increase the priority of further optimizations (currently representing DFINITY at ETHDenver, so I'll most likely take another look at this after March 5). If anyone reading this is at the convention, definitely come say hi! :) |
Version |
currently with complex projects it takes a couple of seconds until the extension is up to date.
e.g. when I type
: Text
to specify the type of a function argument, i can hover the text with my cursor and watch the progress of the tool with the info text updating likeunbound type T
unbound type Te
unbound type Tex
The text was updated successfully, but these errors were encountered: