Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Update Profile' form logic needs to be fixed #79

Closed
adityamahajan-io opened this issue Oct 3, 2020 · 9 comments
Closed

'Update Profile' form logic needs to be fixed #79

adityamahajan-io opened this issue Oct 3, 2020 · 9 comments
Assignees
Labels
Open for contribution Anyone can message and whoever does first can start working on it

Comments

@adityamahajan-io
Copy link
Collaborator

The 'update profile' form does not update the actual values. There are problems with the logic.
Read the API docs on https://skboard.herokuapp.com/ and refer to the update profile section.

@adityamahajan-io adityamahajan-io added Hacktoberfest Open for contribution under Hacktoberfest 2020 help wanted Extra attention is needed labels Oct 3, 2020
@khushi2912
Copy link
Contributor

Can this be assigned to me? I would love working on this

@adityamahajan-io
Copy link
Collaborator Author

Sure! You've been assigned 👍 You will need to develop on a live local server for this. You can use the live server extension on VS-Code for it.
Files to be checked - updateform.js, updateProfile.js

@adityamahajan-io
Copy link
Collaborator Author

Sure! You've been assigned 👍 You will need to develop on a live local server for this. You can use the live server extension on VS-Code for it.
Files to be checked - updateform.js, updateProfile.js

Expected result - The update form should be pre-filled with the existing values fetched from the API. User can edit any field as required

@khushi2912
Copy link
Contributor

Sure! You've been assigned 👍 You will need to develop on a live local server for this. You can use the live server extension on VS-Code for it.
Files to be checked - updateform.js, updateProfile.js

Expected result - The update form should be pre-filled with the existing values fetched from the API. User can edit any field as required

Okay sure!

@adityamahajan-io adityamahajan-io linked a pull request Oct 4, 2020 that will close this issue
@khushi2912
Copy link
Contributor

Sure! You've been assigned 👍 You will need to develop on a live local server for this. You can use the live server extension on VS-Code for it.
Files to be checked - updateform.js, updateProfile.js

Expected result - The update form should be pre-filled with the existing values fetched from the API. User can edit any field as required

I solved the issue to get the pre-filled form during updating, but the submit button doesn't redirect anywhere, should I fix that too?

@adityamahajan-io
Copy link
Collaborator Author

@

Sure! You've been assigned 👍 You will need to develop on a live local server for this. You can use the live server extension on VS-Code for it.
Files to be checked - updateform.js, updateProfile.js

Expected result - The update form should be pre-filled with the existing values fetched from the API. User can edit any field as required

I solved the issue to get the pre-filled form during updating, but the submit button doesn't redirect anywhere, should I fix that too?

@khushi2912 Sure! You can redirect it to the listing page (index.html)
Optional : If possible, you can also try adding a sweetalert similar to what we have at login

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Stale issue message

@tejasmorkar
Copy link
Member

Is there any follow up on this issue @adityamahajan-io ?

@tejasmorkar tejasmorkar removed the Hacktoberfest Open for contribution under Hacktoberfest 2020 label Mar 22, 2021
@adityamahajan-io
Copy link
Collaborator Author

This issue is open for contribution

@tejasmorkar tejasmorkar added Open for contribution Anyone can message and whoever does first can start working on it and removed help wanted Extra attention is needed no-issue-activity labels Mar 24, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open for contribution Anyone can message and whoever does first can start working on it
Projects
None yet
Development

No branches or pull requests

3 participants