Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Verify if the color field matches one of the SVG colors #1688

Open
1 task done
Panquesito7 opened this issue Feb 24, 2023 · 2 comments
Open
1 task done
Labels
devops Use this label for devops related enhancements enhancement

Comments

@Panquesito7
Copy link
Member

I have searched through the issues and didn't find my problem.

  • Confirm

Problem

It'd be great if there's a workflow that checks the color field and makes sure it matches one of the colors in the SVG.
If we optimize the icons, the colors will be always in HEX format, rather than RGB format, which can make it easier.

This will also prevent the maintainers the need to check the color manually.
They should still check it to see if it's a well-chosen color, though.

Possible Solution

Add a workflow that checks the color field of a newly added icon, and if it matches one of the SVG (non-font) colors, it will pass, otherwise, fail.

Additional information

No response

@Panquesito7 Panquesito7 added enhancement devops Use this label for devops related enhancements labels Feb 24, 2023
@Snailedlt
Copy link
Collaborator

Sounds like a feature that should be added to the analyzer script: #1623

@ConX
Copy link
Contributor

ConX commented Mar 16, 2023

@Panquesito7, I like this idea, and it shouldn't be hard to add to the analyzer script, as @Snailedlt suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
Status: To-do
Development

No branches or pull requests

3 participants