[BUG] Incorrect references in devicon.json

[lunatic-fox]

I have searched through the issues and didn't find my problem.

• Confirm

Bug description

In devicon.json some entry objects are with incorrect references in versions.svg[] or aliases[].

Example in heroku entry

• [ x ] SVG array equals SVG files

{
    "svg": [
        "original",
        "original wordmark",
        "plain",
        "plain-wordmark"
    ],
    "font": [
        "original",
        "original wordmark",
        "plain",
        "plain-wordmark",
        "line",
        "line-wordmark"
    ]
}

All detailed information are wrapped in this gist.

Possible fixes or solutions

It's possible to create a program to fix the entire file or make separated PRs to fix each entry.

Additional information

No response

[Snailedlt]

I don't understand this issue. Could you rephrase?

[Snailedlt]

Ohh right, so this is infact multiple issues with devicon.json right? font contains more icons than svg. Duplicate tags, missing attributes, etc?

[lunatic-fox]

Updated and re-writed in Python analyzer: gist

By doing that, one idea came to my mind: maybe we can lint error messages as "yml", that way we have some highlights text, which seems to be good. 🙂

[ConX]

@lunatic-fox I was about to submit an issue for the same problem, but I had only found the codepen and heroku aliases when attempting to build the develop branch.

I think that it would be best to modify your script to make the necessary changes and apply them to the develop branch in a new PR. Additionally, your script should become part of the actions that run when a new-icon/update-icon PR is made.

If you and @Snailedlt agree, I can work during the weekend on either of those.

[Snailedlt]

@ConX Sounds like a good idea to make the changes in a new PR.

I think that it would be best to modify your script to make the necessary changes and apply them to the develop branch in a new PR.

Good idea! I think it would be better to do the changes in a separate script though. That way we can have one script for analyzing the errors, and another (which uses the analyzer script) to make the necessary changes.

Additionally, your script should become part of the actions that run when a new-icon/update-icon PR is made.

Agreed, that would be this workflow I think: https://github.com/devicons/devicon/blob/1119b9f84c0290e0f0b38982099a2bd027a48bf1/.github/workflows/build_icons.yml

[ConX]

@Snailedlt I just submitted a PR (#1623) which is based on this script by @lunatic-fox. Let me know what you think about it.