-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Incorrect references in devicon.json
#1502
Comments
I don't understand this issue. Could you rephrase? |
Ohh right, so this is infact multiple issues with devicon.json right? font contains more icons than svg. Duplicate tags, missing attributes, etc? |
Updated and re-writed in Python analyzer: gist By doing that, one idea came to my mind: maybe we can lint error messages as "yml", that way we have some highlights text, which seems to be good. 🙂 |
@lunatic-fox I was about to submit an issue for the same problem, but I had only found the I think that it would be best to modify your script to make the necessary changes and apply them to the If you and @Snailedlt agree, I can work during the weekend on either of those. |
@ConX Sounds like a good idea to make the changes in a new PR.
Good idea! I think it would be better to do the changes in a separate script though. That way we can have one script for analyzing the errors, and another (which uses the analyzer script) to make the necessary changes.
Agreed, that would be this workflow I think: https://github.com/devicons/devicon/blob/1119b9f84c0290e0f0b38982099a2bd027a48bf1/.github/workflows/build_icons.yml |
@Snailedlt I just submitted a PR (#1623) which is based on this script by @lunatic-fox. Let me know what you think about it. |
I have searched through the issues and didn't find my problem.
Bug description
In
devicon.json
some entry objects are with incorrect references inversions.svg[]
oraliases[]
.Example in heroku entry
All detailed information are wrapped in this gist.
Possible fixes or solutions
It's possible to create a program to fix the entire file or make separated PRs to fix each entry.
Additional information
No response
The text was updated successfully, but these errors were encountered: