-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTHER] Alphabetically order devicon.json #1337
Comments
We could make a PR after merging the current PRs. There're a bunch online tools to reorder JSON's + format document (spaces, lines, etc.) |
Yeah. I think the best thing would be to use a linter like prettier or eslint to automatically sort it alphabetically when a new PR is created or something. But that might be a bit of work to implement unless someone here has done it before :) |
In my opinion the easiest way for now would be to create a PR to lint the file, and check if users place correctly the new entry, and finally add an EditorConfig helps maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs. See https://editorconfig.org/ , I used it in multiple projects and it's compatible with all majors IDEs. The advantage of EditorConfig is that it's very simple to add to a project and you have nothing to do after that, no installation, no maintenance, etc... For Devicon, we can only configure the JSON and SVG extensions, something like:
The idea to add a new action step to the merge process is still a valid good addition but since it can be a bit more complexe to setup maybe we can start with manual check and EditorConfig for formatting. |
@BenSouchet sounds like a good start. Do you want to add it? |
@Snailedlt I just created this PR #1344 😊 |
In the PR I mention in my prev comment, I talk about spectral, a JSON linter that can be useful, and can maybe be linked in this project when a PR is merge in develop, or as an hook when maintainers add specific tag to a PR |
Nice! I'll take a look soon (hopefully). Added Panquesito as a reviewer too |
I have searched through the issues and didn't find my problem.
What would you like to share?
Due to some recent merges, the devicon.json file has become unprdered. This should be fixed as soon as possible, and at the very least before the next release.
Additional information
Alphabetically ordering the file wilø make it easier to find icons, as well as making it less likely to cause conflicts with future updates to it.
The text was updated successfully, but these errors were encountered: