Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagery and timeframe selection #30

Merged
merged 272 commits into from
Jan 22, 2024
Merged

Add imagery and timeframe selection #30

merged 272 commits into from
Jan 22, 2024

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Feb 1, 2023

Remaining tasks:

  • Load AOI previous inferences
  • Display timeframe tiles after switching AOIs
  • Keyboard shortcuts
  • Export AOI
  • Disable "Edit AOI" messages until feature is reinstated

@vgeorge vgeorge marked this pull request as draft February 1, 2023 14:26
@LanesGood
Copy link
Member

@vgeorge when testing, I see two issues:

  • there are two mosaics present in the southern hemisphere (NAIP and sentinel), and only one in the northern (NAIP). Test locations for northern hemisphere = Washington DC & New Mexico US. Test locations for southern hemisphere = Peru and Brazil.
  • When I create an AOI and then select a base mosaic, if I delete my AOI the base mosaic is still selected. To protect against potential issues, we should probably remove the selected base mosaic if the AOI is deleted and there is not already an existing AOI on the project.

@LanesGood
Copy link
Member

@vgeorge initial style handled for now. Can we truncate the bounds?
image

@vgeorge
Copy link
Member Author

vgeorge commented Feb 7, 2023

@LanesGood thanks for the review. Here are some notes about the changes I made now:

  • Added imagery source selector, now the selection sequence is AOI -> Imagery Source -> Mosaic -> Model
  • Mosaic and Model list depends on the selected Imagery Source
  • Hardcoded data for Imagery Source/Mosaics were updated, but only NAIP should work for running a prediction for now
  • The Mosaic selector is a modal, should we use a dropdown as in Figma prototype? It is not clear to me which metadata will we display in cards for Imagery Sources and Mosaics, as this depends on the ongoing API implementation. I used the existing mosaic modal as a base for both of them
  • Deleting the current AOI clears selected imagery/mosaic/model
  • Update labels for selectors

I'm not planning on adding further changes until developmentseed/pearl-backend#43 is added to developmentseed/pearl-backend#38. I believe it would be better to have them ready before we finish hooking the logic to the UI.

cc @geohacker

@LanesGood
Copy link
Member

LanesGood commented Feb 9, 2023

@vgeorge yes, I think the preset mosiac timeframe selection should come from a dropdown list, if it is possible to format as [Jan -Mar 2022, Apr - Jun 2022, Jul - Sep 2022] etc.

Should we use the term "mosaic" in the UI? I think "Timeframe" is more approachable for users, but am not certain if this is 100% accurate.

Deleting the current AOI clears selected imagery/mosaic/model

To confirm, this sounds correct when no AOI/prediction run has yet been executed. When a prediction has already been run, we don't need to clear the imagery/mosaic/model

@vgeorge vgeorge mentioned this pull request Mar 7, 2023
5 tasks
# Conflicts:
#	app/assets/scripts/fsm/project/machine.js
# Conflicts:
#	app/assets/scripts/fsm/project/machine.js
Move mock API routes payloads into separate files
@vgeorge vgeorge marked this pull request as ready for review January 18, 2024 13:08
@vgeorge
Copy link
Member Author

vgeorge commented Jan 22, 2024

As part of the branch reorganization described in #71, this is ready to be merged.

@vgeorge vgeorge merged commit 4edf6c9 into develop Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants