Merge pull request #64 from developmentseed/enhance/upgrade-nodejs

Upgrade Node.js to v18
developmentseed · Jan 2, 2024 · 2e5d60b · 2e5d60b
2 parents d963102 + 7bcad12
commit 2e5d60b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 19 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -22,10 +22,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
-      - name: Use Node.js 14
+      - name: Use Node.js 18
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 18
 
       - name: Cache node modules
         id: cache-node-modules
@@ -60,10 +60,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
-      - name: Use Node.js 14
+      - name: Use Node.js 18
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 18
 
       - name: Cache node modules
         id: cache-node-modules
@@ -101,10 +101,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
-      - name: Use Node.js 14
+      - name: Use Node.js 18
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 18
 
       - name: Cache node modules
         id: cache-node-modules

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -26,12 +26,12 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v2
-        
-      - name: Use Node.js 14
+
+      - name: Use Node.js 18
         uses: actions/setup-node@v1
         with:
-          node-version: 14
-      
+          node-version: 18
+
       - name: Cache node modules
         id: cache-node-modules
         uses: actions/cache@v2
@@ -44,7 +44,7 @@ jobs:
             ${{ runner.os }}-build-${{ env.cache-name }}-
             ${{ runner.os }}-build-
             ${{ runner.os }}-
-            
+
       - name: Install
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: yarn install
@@ -59,7 +59,7 @@ jobs:
       - name: Build Prod
         if: github.ref == 'refs/heads/main'
         run: yarn build
-        
+
       - name: Azure Login
         if: github.ref == 'refs/heads/develop'
         uses: azure/login@v1
@@ -72,21 +72,19 @@ jobs:
         with:
           creds: ${{ secrets.AZURE_CREDENTIALS_PRODUCTION }}
 
-
       - name: Upload to blob storage
         if: github.ref == 'refs/heads/develop'
         uses: azure/CLI@v1
         with:
           inlineScript: |
-              az storage blob upload-batch --account-name $STAGING_STORAGE_ACCOUNT_NAME --overwrite -d '$web' -s ./dist
+            az storage blob upload-batch --account-name $STAGING_STORAGE_ACCOUNT_NAME --overwrite -d '$web' -s ./dist
 
       - name: Upload to blob storage
         if: github.ref == 'refs/heads/main'
         uses: azure/CLI@v1
         with:
           inlineScript: |
-              az storage blob upload-batch --account-name $PRODUCTION_STORAGE_ACCOUNT_NAME --overwrite -d '$web' -s ./dist
-
+            az storage blob upload-batch --account-name $PRODUCTION_STORAGE_ACCOUNT_NAME --overwrite -d '$web' -s ./dist
 
       - name: Purge CDN endpoint
         if: github.ref == 'refs/heads/develop'
@@ -102,6 +100,5 @@ jobs:
           inlineScript: |
             az cdn endpoint purge --content-paths  "/*" --profile-name $PRODUCTION_CDN_PROFILE_NAME --name $PRODUCTION_CDN_ENDPOINT --resource-group $PRODUCTION_RESOURCE_GROUP
 
-
       - name: Azure Logout
         run: az logout
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-14
+18
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
     "cy:run": "NODE_ENV=cypress cypress run --e2e --browser electron"
   },
   "engines": {
-    "node": "14.x"
+    "node": "18.x"
   },
   "browserify": {
     "transform": [