-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable s2c packet duplication #44
Conversation
Servers with this mvdsv patch: Vortex (Spanish) and Nicotine Lounge (USA) |
Non updated clients will still be able to get packets though, right? Will they just ignore duplicated packets? |
Yes they will. The good thing in implementing s2c (server to client) packet dup in mvdsv is that it doesn't matter what client is being used, the packets will get through anyway. because mvdsv will send them.
server rate? (edit: i understood. long story short, the client will receive the packets anyway, even if it isn't updated. orginal answer below) it's a good idea to limit the number of dupes in the code. |
Linked to meag/ezquake-source#3 |
for posterity: |
thats a good suggestion. |
Qizmo-esque "/setinfo dupe 1" in client Maximum value set at 3 for the moment Disabled while downloading files Closes QW-Group#44
Qizmo-esque "/setinfo dupe 1" in client Maximum value set at 3 for the moment Disabled while downloading files Closes QW-Group#44
Qizmo-esque "/setinfo dupe 1" in client Maximum value set at 3 for the moment Disabled while downloading files Closes QW-Group#44
upping this. Let's merge this PR, please. It could help players that still have PL issues. |
MVDSV implementation:
setinfo dupe 0-5
The new server cvar. A client sets a "dupe" value between 0 (no packet duplication, normal behavior) and 5 (5 packets duplicated).
setinfo dupe 1
sends one duplicated packet to the client. With higher dupe values, the default mvdsv rate limit of 50000 isn't enough for a busy fight - read nails - (and rate cut happens). Hence the change to the hard-coded mvdsv rate limit of 100000, enabling server admins to set higher rate limit. From my tests, a value of 1 or 2 if fine for rate 50000 with lots of nails (stress test).Testing
You can see this in action with the command
showpackets 1
(this command is implemented in the netchan itself - client and server - but the outbound duplicated packets aren't shown )<-- is 'inbound' | --> is 'outbound'
So with dupe 0 and no packetloss, you should get an equal number of --> and <-- lines
but with dupe >=1, you'll get duplicated <-- lines
This works for every client that connects to mvdsv. It doesn't matter if the client uses qwfwd or not - the packets are duplicated from the server to the client.
All this is already featured in FTE.
Credits to Spike