Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incase of last 5 seconds remaining, don't connect. Wait. #11

Open
olttwa opened this issue Mar 14, 2017 · 2 comments
Open

Incase of last 5 seconds remaining, don't connect. Wait. #11

olttwa opened this issue Mar 14, 2017 · 2 comments

Comments

@olttwa
Copy link

olttwa commented Mar 14, 2017

If only 5 seconds are remaining on the google auth timer, by the time the password we type in reaches point of authentication, it has expired. These cases lead to failure of auth. In case only 5 seconds or lesser are remaining, we should wait until we get the new password, then connect to VPN.

  • Also, we can keep the last seconds remaining configurable. Because in times of bad internet connections, I have seen that this thing matters a lot.
@ikouchiha47
Copy link

This extra check is not needed, in case of failure, the management console will receive a request for re-authentication, and then will go into the normal flow of the app.

@detj
Copy link
Owner

detj commented Mar 14, 2017

@olttwa Thanks for pointing this out. Yeah, the timing mismatch between password generation and server authentication is a problem.
These won't be an issue once moor interfaces directly with openvpn using its management interface. Timing should not be problem in this case as there is no step where the user has to intervene, unlike the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants