fix: return proper error message when moving a project with a matching names #9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9795 +/- ##
==========================================
- Coverage 54.07% 54.04% -0.03%
==========================================
Files 1260 1260
Lines 155574 155585 +11
Branches 3503 3503
==========================================
- Hits 84120 84090 -30
- Misses 71308 71349 +41
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keita-determined
approved these changes
Aug 5, 2024
| silent: false, | ||
| type: ErrorType.Server, | ||
| }); | ||
| if (e instanceof DetError && e.type === ErrorType.Server) { |
There was a problem hiding this comment.
only difference here is publicMessage, so i think we can use ternary operator.
AmanuelAaron
changed the title
keita-determined
approved these changes
Aug 5, 2024
jesse-amano-hpe
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-626
Description
Display message for matching name error when moving projects
Test Plan
Create two projects with the same name in separate workspaces. Move one project to the workspace of the other and confirm that the error message is
Project with name '{project_name}' already exists in target workspaceChecklist
docs/release-notes/See Release Note for details.