patch: make groups scope optional to support azure with OIDC (#9773) #9778
+68
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.34.0 #9778 +/- ##
==================================================
+ Coverage 49.83% 52.21% +2.37%
==================================================
Files 1247 753 -494
Lines 162284 112450 -49834
Branches 2887 2888 +1
==================================================
- Hits 80878 58712 -22166
+ Misses 81234 53566 -27668
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
tara-det-ai
reviewed
Aug 23, 2024
| managers in the cluster. | ||
|
|
||
| **NOTE:** ``resource_manager.cluster_name`` is separate from the ``cluster_name`` field of the |
There was a problem hiding this comment.
Suggested change
| **NOTE:** ``resource_manager.cluster_name`` is separate from the ``cluster_name`` field of the | |
| .. note:: | |
| The `resource_manager.cluster_name` is distinct from the `cluster_name` field in the master configuration, which provides a readable name for the Determined deployment. |
tara-det-ai
reviewed
Aug 23, 2024
| managers in the cluster. | ||
|
|
||
| **NOTE:** ``resource_manager.cluster_name`` is separate from the ``cluster_name`` field of the | ||
| master config that provides a readable name for the Determined deployment. |
There was a problem hiding this comment.
Suggested change
| master config that provides a readable name for the Determined deployment. |
tara-det-ai
reviewed
Aug 23, 2024
| ``always_redirect`` | ||
| =================== | ||
|
|
||
| Specifies if this OIDC provider should be used for authentication, bypassing the standard Determined |
There was a problem hiding this comment.
Suggested change
| Specifies if this OIDC provider should be used for authentication, bypassing the standard Determined | |
| Specifies whether this OIDC provider should be used for authentication, bypassing the standard Determined |
tara-det-ai
reviewed
Aug 23, 2024
| =================== | ||
|
|
||
| Specifies if this OIDC provider should be used for authentication, bypassing the standard Determined | ||
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If an |
There was a problem hiding this comment.
Suggested change
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If an | |
| sign-in page. This redirection persists unless the user explicitly signs out via the WebUI. If an |
tara-det-ai
reviewed
Aug 23, 2024
|
|
||
| Specifies if this OIDC provider should be used for authentication, bypassing the standard Determined | ||
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If an | ||
| SSO user attempts to use an expired session token, they are directly redirected to the SSO provider |
There was a problem hiding this comment.
Suggested change
| SSO user attempts to use an expired session token, they are directly redirected to the SSO provider | |
| SSO user attempts to use an expired session token, they will be redirected to the SSO provider |
tara-det-ai
reviewed
Aug 23, 2024
| ``exclude_groups_scope`` | ||
| ======================== | ||
|
|
||
| Specifies if the groups scope should be excluded for this OIDC provider. For most OIDC providers |
There was a problem hiding this comment.
Suggested change
| Specifies if the groups scope should be excluded for this OIDC provider. For most OIDC providers | |
| Indicates whether the groups scope should be excluded for this OIDC provider. For most OIDC providers |
tara-det-ai
reviewed
Aug 23, 2024
| ======================== | ||
|
|
||
| Specifies if the groups scope should be excluded for this OIDC provider. For most OIDC providers | ||
| such as Okta, this should be false (or blank) if you'd like to provision group memberships. But for |
There was a problem hiding this comment.
Suggested change
| such as Okta, this should be false (or blank) if you'd like to provision group memberships. But for | |
| such as Okta, this should be set to false (or blank) if you want to provision group memberships. However, for |
tara-det-ai
reviewed
Aug 23, 2024
| ``always_redirect`` | ||
| =================== | ||
|
|
||
| Specifies if this SAML provider should be used for authentication, bypassing the standard Determined |
There was a problem hiding this comment.
Suggested change
| Specifies if this SAML provider should be used for authentication, bypassing the standard Determined | |
| Specifies whether this SAML provider should be used for authentication, bypassing the standard Determined |
tara-det-ai
reviewed
Aug 23, 2024
| =================== | ||
|
|
||
| Specifies if this SAML provider should be used for authentication, bypassing the standard Determined | ||
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If a |
There was a problem hiding this comment.
Suggested change
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If a | |
| sign-in page. This redirection persists unless the user explicitly signs out via the WebUI. If a |
tara-det-ai
reviewed
Aug 23, 2024
|
|
||
| Specifies if this SAML provider should be used for authentication, bypassing the standard Determined | ||
| sign-in page. This redirection persists unless the user explicitly signs out within the WebUI. If a | ||
| SSO user attempts to use an expired session token, they are directly redirected to the SAML provider |
There was a problem hiding this comment.
Suggested change
| SSO user attempts to use an expired session token, they are directly redirected to the SAML provider | |
| SSO user attempts to use an expired session token, they will be redirected to the SAML provider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-407
Description
Draft for customer demo requiring Azure/Entra auth only
Test Plan
Tested and merged into main for 0.35.0 release already
Checklist
docs/release-notes/See Release Note for details.