-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate kubernetes priority w/ preemption scheduler #9763
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9763 +/- ##
==========================================
- Coverage 54.26% 54.19% -0.08%
==========================================
Files 1261 1261
Lines 155671 155680 +9
Branches 3536 3534 -2
==========================================
- Hits 84481 84365 -116
- Misses 71052 71177 +125
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ab89609
to
c7dd0d9
Compare
f1c4e92
to
5229ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left some questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
CM-385
Description
Deprecate the Kubernetes priority with preemption scheduler. Remove references to the helm chart & invalidate master configuration input
defaultScheduler: preemption
. Set thepreemption
value for all kubernetes resource managers to false (since now no scheduler has preemption enabled).Test Plan
No testing needed, but manual testing shows that defining
defaultScheduler: preemption
in the yaml chart will be overwritten by a blank default value to the master configuration. Also, trying to definedefaultScheduler: preemption
in a devcluster yaml's master configuration won't be recognized as valid.Checklist
docs/release-notes/
See Release Note for details.