fix: edit/move modals for projects in workspaces unexpectedly closes [DET-10388] #9588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9588 +/- ##
==========================================
- Coverage 49.86% 45.26% -4.61%
==========================================
Files 1247 923 -324
Lines 162293 121980 -40313
Branches 2887 2887
==========================================
- Hits 80922 55209 -25713
+ Misses 81200 66600 -14600
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eecsliu
requested review from
a team
and removed request for
a team and
keita-determined
gt2345
reviewed
Jun 27, 2024
|
|
||
| if (!_.isEqual(workspaceAssignments, response.assignments)) { | ||
| setWorkspaceAssignments(response.assignments); | ||
| } |
There was a problem hiding this comment.
I prefer to write this kind of logic as something like
setWorkspaceAssignments(prev => _.isEqual(prev, response.assignments) ? prev : response.assignments);
gt2345
approved these changes
Jun 27, 2024
eecsliu
force-pushed
the
fix-project-modals-closing
branch
from
73e072b
to
bc7c824
Compare
keita-determined
added
the
to-cherry-pick
keita-determined
approved these changes
Jun 27, 2024
| _.isEqual(prev, response.assignments) ? prev : response.assignments, | ||
| ); | ||
| } catch (e) { | ||
| handleError(e, { silent: true }); |
There was a problem hiding this comment.
Suggested change
| handleError(e, { silent: true }); | |
| handleError(e, { silent: false }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Projects (under workspaces) modals get closed randomly when in list view and RBAC enabled. This change band-aids the problem by making sure the problematic code doesn't get called unless it has to.
Test Plan
Checklist
docs/release-notes/See Release Note for details.