Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connect modal for notebook and shell tasks [MD-404] #9545

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Jun 20, 2024

Ticket

Description

Adds a modal that displays connect options for active shell and notebook tasks.

Test Plan

  1. start a shell or notebook task.
  2. verify that there is a "Connect" option in the task dropdown
image
  1. Connect should open a modal that contains:
    • remote server address for jupyter notebook
image
- `det shell open ID` command for shells
  1. verify that clipboard functionality works

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1c849a5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6674a1850e72b9000834aa60
😎 Deploy Preview https://deploy-preview-9545--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined
Copy link
Contributor

im on it

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you format and lint files?


bug?:
sometimes, ok button got frozen. not sure if its from this code or not. i didnt see it in other place though.

Screen.Recording.2024-06-20.at.11.18.03.AM.mov

webui/react/src/components/TaskConnectModal.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskConnectModal.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 8.51064% with 86 lines in your changes missing coverage. Please review.

Project coverage is 45.20%. Comparing base (325d47e) to head (1c849a5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9545      +/-   ##
==========================================
- Coverage   49.84%   45.20%   -4.65%     
==========================================
  Files        1246      923     -323     
  Lines      162007   121796   -40211     
  Branches     2886     2887       +1     
==========================================
- Hits        80760    55063   -25697     
+ Misses      81076    66561   -14515     
- Partials      171      172       +1     
Flag Coverage Δ
harness ?
web 46.20% <8.51%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/types.ts 99.68% <100.00%> (+<0.01%) ⬆️
webui/react/src/components/TaskList.tsx 0.00% <0.00%> (ø)
webui/react/src/components/TaskConnectModal.tsx 0.00% <0.00%> (ø)
webui/react/src/components/TaskActionDropdown.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but i have a concern to replace AnyTask with CommandTask. can we make sure the input is always CommandTask or can be AnyTask.

webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskActionDropdown.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TaskList.tsx Show resolved Hide resolved
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@azhou-determined azhou-determined merged commit 83b9a8b into main Jun 20, 2024
84 of 97 checks passed
@azhou-determined azhou-determined deleted the webui-task-connect-modal branch June 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants