Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit lint check fix #9543

Merged
merged 1 commit into from
Jun 20, 2024
Merged

pre-commit lint check fix #9543

merged 1 commit into from
Jun 20, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Jun 20, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0880048
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66745076606c18000867cde7

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.87%. Comparing base (553521e) to head (0880048).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9543      +/-   ##
==========================================
- Coverage   49.85%   43.87%   -5.98%     
==========================================
  Files        1246     1071     -175     
  Lines      162007   149101   -12906     
  Branches     2887     2887              
==========================================
- Hits        80763    65416   -15347     
- Misses      81073    83514    +2441     
  Partials      171      171              
Flag Coverage Δ
harness 37.83% <ø> (-25.98%) ⬇️
web 46.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 276 files with indirect coverage changes

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol LGTM

@azhou-determined azhou-determined merged commit 325d47e into main Jun 20, 2024
59 of 96 checks passed
@azhou-determined azhou-determined deleted the fix-precommit-hook branch June 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants