Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: det framework supports "nth" component [testeng-1] #9540

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Jun 18, 2024

Ticket

[testeng-1]

Description

code is base component is commented. the test case in experiment list is updated with it

I doublechecked every case I could think of in the debugger. Luckily, the test scenario has all the use cases I can think of.
Here's what I do when I create an nth element:

  • update locator of nth element (clone of original element)
  • any properties in nth which have a parent that refer to original get a clone. update the clone parent to the clone and recurse
  • any properties in newChild which have a parent that refer to original child get a clone. update the clone parent to newChild clone and recurse

All these things should be working:

secondRow = row.nth(1)
secondRow.pwlocator
secondRow.A.pwlocator
secondRow.componentWithParentAsA.pwlocator
secondRow.A.directChildOfA.pwlocator
secondRow.A.B.pwlocator

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@JComins000 JComins000 requested a review from a team as a code owner June 18, 2024 19:47
@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.45%. Comparing base (f9ba7f4) to head (74ca4ac).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9540      +/-   ##
==========================================
- Coverage   49.28%   44.45%   -4.83%     
==========================================
  Files        1242      918     -324     
  Lines      161444   121170   -40274     
  Branches     2868     2868              
==========================================
- Hits        79570    53869   -25701     
+ Misses      81702    67129   -14573     
  Partials      172      172              
Flag Coverage Δ
harness ?
web 44.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 74ca4ac
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6671e8b46fa1e0000898e8a3
😎 Deploy Preview https://deploy-preview-9540--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djanicekpach djanicekpach self-requested a review June 18, 2024 19:54
@JComins000 JComins000 force-pushed the jcom/TESTENG-1/nth-element-support branch from 420dde9 to c7b31d7 Compare June 18, 2024 19:59
Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me assuming tests still pass

webui/react/src/e2e/models/BaseComponent.ts Outdated Show resolved Hide resolved
@JComins000 JComins000 force-pushed the jcom/TESTENG-1/nth-element-support branch from c7b31d7 to 74ca4ac Compare June 18, 2024 20:06
@JComins000 JComins000 merged commit ea929fc into main Jun 18, 2024
84 of 97 checks passed
@JComins000 JComins000 deleted the jcom/TESTENG-1/nth-element-support branch June 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants