test: increase timeouts for running experiments on k8s after env split #9530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9530 +/- ##
==========================================
- Coverage 49.28% 49.28% -0.01%
==========================================
Files 1242 1242
Lines 161477 161477
Branches 2868 2867 -1
==========================================
- Hits 79585 79584 -1
- Misses 81720 81721 +1
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -17,8 +17,8 @@ def __init__(self) -> None: | |||
|
|
|||
| # Verify we have pulled our image. | |||
| # TODO this won't work if we have multiple nodes. | |||
| utils.wait_for_command_state(sess, utils.run_command(sess, 0, slots=0), "TERMINATED", 300) | |||
| utils.wait_for_command_state(sess, utils.run_command(sess, 0, slots=1), "TERMINATED", 300) | |||
| utils.wait_for_command_state(sess, utils.run_command(sess, 0, slots=0), "TERMINATED", 600) | |||
There was a problem hiding this comment.
nit (non-blocking): Would it be worth while to define this timeout duration as a constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Fix flakey test https://app.circleci.com/pipelines/github/determined-ai/determined/57030/workflows/987af866-5aed-4ff1-825d-1c7dcff5deee/jobs/2681147
Images got a lot larger after framework split so increase timeout.
Test Plan
ci passes
Checklist
docs/release-notes/.See Release Note for details.