Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow empty run metadata requests to delete existing metadata #9524

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Jun 14, 2024

Ticket

ET-307

Description

Enables empty an metadata field to be submitted through both the Core API & API endpoints, allowing existing metadata to be deleted internally.

Cleans up an unnecessary todo from TestFlattenMetadataNil about returning an error when the provided metadata is empty, this no longer was the decided case since the expectation is to delete existing metadata when the provided metadata is empty.

Test Plan

  • TestFlattenMetadataNil
  • TestFlattenMetadata
  • TestPostRunMetadata

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 28ccb21
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666c44b2e27b6a0008df256f

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.28%. Comparing base (b51bc93) to head (28ccb21).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9524   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files        1242     1242           
  Lines      161442   161442           
  Branches     2868     2868           
=======================================
  Hits        79570    79570           
  Misses      81700    81700           
  Partials      172      172           
Flag Coverage Δ
backend 43.90% <33.33%> (ø)
harness 63.81% <ø> (ø)
web 44.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_runs.go 63.23% <ø> (+0.03%) ⬆️
master/internal/run/runs.go 87.09% <100.00%> (ø)
master/internal/db/postgres_runs.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@corban-beaird corban-beaird merged commit 3320107 into main Jun 18, 2024
88 of 102 checks passed
@corban-beaird corban-beaird deleted the corban-remove-todo-comment branch June 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants