Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links #9523

Merged
merged 1 commit into from
Jun 13, 2024
Merged

docs: Fix broken links #9523

merged 1 commit into from
Jun 13, 2024

Conversation

tara-det-ai
Copy link
Member

@tara-det-ai tara-det-ai commented Jun 13, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci requested a review from a team June 13, 2024 21:16
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jun 13, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f7424e7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666b61ade9cb2400082ffc26

@@ -9,9 +9,8 @@
.. meta::
:description: Follow along with this batch inferencing tutorial to see how to leverage Determined and Pachyderm together to streamline complex tasks.

In this guide, we'll help you create a simple batch inferencing project in `Pachyderm
<https://docs.pachyderm.com/latest/learn/glossary/pipeline/>`__, train your model using a Determined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems to work for me.
See:

(tutorials/pachyderm-cat-dog: line 12) redirect https://docs.pachyderm.com/latest/learn/glossary/pipeline/ - permanently to https://docs.pachyderm.com/products/mldm/latest/learn/glossary/pipeline/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should not have been there

@@ -23,8 +22,8 @@ cluster, and then use the model in an inferencing pipeline.
************

After completing the steps in this tutorial, you will have a a fully-built batch inferencing
`pipeline <https://docs.pachyderm.com/latest/learn/glossary/pipeline/>`__ with results and you will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

Copy link
Member Author

@tara-det-ai tara-det-ai Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this one out because of some upcoming changes to the Hugo docs

@@ -130,9 +130,8 @@ You are now ready to create a project repo.
Create Repos in Pachyderm for Training Data
*********************************************

To manage our training data effectively, we'll first need to create `repos
<https://docs.pachyderm.com/latest/learn/basic-concepts/#basic-concepts-repositories-repo>`_ for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@tara-det-ai tara-det-ai Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it due to its (now) awkwardness

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real broken link is:

1:release-notes.rst:2482: [broken] https://0pointer.de/blog/projects/socket-activation.html:HTTPSConnectionPool(host='0pointer.de', port=443): Max retries exceeded with url: /blog/projects/socket-activation.html

I don't see a fix for it in this PR

Ignore this, it was a flake...

@tara-det-ai tara-det-ai merged commit b51bc93 into main Jun 13, 2024
90 of 103 checks passed
@tara-det-ai tara-det-ai deleted the docs/Fix-broken-links branch June 13, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants