Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use num pods in k8 job summary #9497

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Jun 11, 2024

Ticket

Description

we recently changed k8 submissions from pods to jobs, but this resource summary object doesn't reflect a job containing multiple pods

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 799d7c8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66686a649fb5d70008b24a1a

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (439734b) to head (799d7c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9497      +/-   ##
==========================================
- Coverage   49.00%   48.99%   -0.01%     
==========================================
  Files        1235     1235              
  Lines      160191   160191              
  Branches     2781     2780       -1     
==========================================
- Hits        78494    78485       -9     
- Misses      81522    81531       +9     
  Partials      175      175              
Flag Coverage Δ
backend 43.82% <100.00%> (-0.02%) ⬇️
harness 63.96% <ø> (ø)
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/kubernetesrm/resource_pool.go 72.53% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would request the the k8s test suite on circleci and wait for it to pass just to be safe

@azhou-determined azhou-determined merged commit de03909 into main Jun 11, 2024
94 of 105 checks passed
@azhou-determined azhou-determined deleted the k8-summary-agentdevice branch June 11, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants