fix: historical allocations not showing task allocation workspace

[eecsliu]

Ticket

DET-10323

Description

Downloading historical allocations resulted in the workspace field being empty for tasks. This is because we queried for experiment workspace, but not task workspace. This PR fixes that issue, and adds test cases to verify the outputted CSV contains the tasks's workspace. This also fixes a broken test (test_notebook_capture).

Test Plan

Make sure e2e_cpu tests pass.

To manually test, run some tasks (notebooks, commands, or tensorboards), then sign in as admin, go to the clusters page, and the historical usage tab. Download the CSV, making sure to select allocations and not workspaces, and verify that the workspace name field is populated for the tasks you ran.

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.00%. Comparing base (439734b) to head (9128977).
Report is 12 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9496   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files        1235     1235           
  Lines      160191   160208   +17     
  Branches     2781     2781           
=======================================
+ Hits        78494    78515   +21     
+ Misses      81522    81518    -4     
  Partials      175      175           

Flag	Coverage Δ
backend	43.87% <0.00%> (+0.02%)	⬆️
harness	63.96% <ø> (ø)
web	44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
master/internal/core.go	6.34% <0.00%> (-0.13%)	⬇️

... and 6 files with indirect coverage changes

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	9128977
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/666a21c55e789a0008217e8d
😎 Deploy Preview	https://deploy-preview-9496--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[MikhailKardash]

Make sure e2e_cpu tests pass.

e2e_cpu does not pass.

[corban-beaird]

Looks like on line 36, int(row["experiment_id"] is resulting an error in the test because it's now sending an empty string instead of 0.

[eecsliu]

good catch! I think the line 36 one is actually ok because we don't have any tasks that cause that case to come up. The failure was in test_tensorboard_experiment_capture. In any case, I fixed both instances!

Edit: my bad, I stand corrected! circleCI showed both erroring out, but my local test was only failing the tensorboard test.

[corban-beaird]

Looks good!