fix: partially scheduled k8s jobs should display as queued #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9468 +/- ##
=======================================
Coverage 49.28% 49.28%
=======================================
Files 1242 1242
Lines 161441 161442 +1
Branches 2868 2868
=======================================
+ Hits 79564 79567 +3
+ Misses 81705 81703 -2
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stoksc
changed the title
kkunapuli
reviewed
Jun 4, 2024
| t.Error("state went to PULLING or beyond when all pods could not have been scheduled") | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: What do you think about adding a couple comments describing what the test is doing / what its goal is? I'm having a hard time following what's setup and what's validation.
NicholasBlaskey
force-pushed
the
stoksc/fix/jobqslots
branch
from
cb3e794
to
bd1eb76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
RM-323
Description
Fixes an issue where we didn't wait for all pod states to make a call about the state of a job.
Test Plan
Has an automated test.
Checklist
docs/release-notes/.See Release Note for details.