Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: readme and test name revisions [TESTENG-5] #9463

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented May 31, 2024

Ticket

TESTENG-5

Description

merge this after #9478
Readme updates. Test name updates. Made a few organization changes along the way.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 31, 2024
Copy link

netlify bot commented May 31, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0387eb7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6663614b93afea0008d96a7e
😎 Deploy Preview https://deploy-preview-9463--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.93%. Comparing base (c49eeea) to head (878f1fa).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9463      +/-   ##
==========================================
- Coverage   51.18%   43.93%   -7.25%     
==========================================
  Files         746      422     -324     
  Lines      110899    70932   -39967     
  Branches     2777     2778       +1     
==========================================
- Hits        56759    31163   -25596     
+ Misses      53966    39595   -14371     
  Partials      174      174              
Flag Coverage Δ
harness ?
web 44.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@JComins000 JComins000 changed the title test: readme revisions and docstring updates [TESTENG-5] test: readme and test name revisions [TESTENG-5] Jun 3, 2024
@JComins000 JComins000 marked this pull request as ready for review June 3, 2024 18:36
@JComins000 JComins000 requested a review from a team as a code owner June 3, 2024 18:36
@JComins000 JComins000 requested review from a team and djanicekpach June 6, 2024 15:27
@JComins000 JComins000 merged commit 869b96a into main Jun 7, 2024
13 of 53 checks passed
@JComins000 JComins000 deleted the jcom/TESTENG-5/readme-revisions branch June 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant