fix: job queue's allocated slots should be correct after restarts #9461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9461 +/- ##
==========================================
+ Coverage 49.00% 49.03% +0.03%
==========================================
Files 1233 1233
Lines 159389 159392 +3
Branches 2778 2778
==========================================
+ Hits 78102 78158 +56
+ Misses 81113 81060 -53
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stoksc
force-pushed
the
stoksc/fix/jobqslots
branch
from
7ffdb71
to
8dbbe1b
Compare
kkunapuli
approved these changes
May 31, 2024
| @@ -766,6 +766,115 @@ func TestReattach(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestJobQueueReattach(t *testing.T) { | |||
stoksc
commented
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What it says on the tin.
..but I also renamed
ScheduletoAdmitbecause it's not scheduling, just deciding to admit tasks to Kubernetes to be scheduled (and from that,rescheduleis nowtryAdmitPendingTasks). My test had a call to schedule followed by an assertion that the job queue's state said we were queued. The name couldn't stand any longer lol.Test Plan
Has automated testing.
Checklist
docs/release-notes/.See Release Note for details.