fix: convert invalid hparam types to json string #9449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9449 +/- ##
==========================================
- Coverage 49.00% 48.99% -0.01%
==========================================
Files 1234 1234
Lines 159671 159677 +6
Branches 2779 2778 -1
==========================================
- Hits 78248 78240 -8
- Misses 81248 81262 +14
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AmanuelAaron
changed the title
AmanuelAaron
changed the title
AmanuelAaron
changed the title
NicholasBlaskey
approved these changes
Jun 5, 2024
master/internal/db/postgres_trial.go
Outdated
| valBytes, err := json.Marshal(v) | ||
| if err != nil { | ||
| return hparamsModel, projHparamsModel, | ||
| fmt.Errorf("cannot assign hyperparameter %s, failed to encode type %T", hpName, val) |
There was a problem hiding this comment.
include the json error here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-292
Description
Instead of throwing an error, we want to convert run hparams that are not text,numbers or dates into strings before being added to the run_hparam perf table
Test Plan
This is a fix for the nightly tests. Specifically
test-e2e-mmdetection. This test should no longer failChecklist
docs/release-notes/.See Release Note for details.