Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the defaults for shared_fs mount in genai correctly #9433

Merged
merged 1 commit into from
May 28, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented May 28, 2024

Ticket

Description

We were not setting the default for the shared_fs mount dir correctly in det deploy aws --deployment-type genai

Test Plan

Deploy a cluster with genai:

det deploy aws up \
    --deployment-type genai \
    --genai-version 0.1.12 \
    --cluster-id YOUR_CLUSTER_HERE \
    --keypair YOUR_KEYPAIR \
    --det-v 0.32.1 \
    --aux-agent-instance-type m5.large \
    --compute-agent-instance-type p3.16xlarge

The master node should have no errors in the efs build in /var/log/cloud-init-output.log nor when mounting to the docker container

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@tayritenour tayritenour requested a review from a team as a code owner May 28, 2024 19:45
@tayritenour tayritenour requested a review from hamidzr May 28, 2024 19:45
@cla-bot cla-bot bot added the cla-signed label May 28, 2024
@tayritenour tayritenour added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit cded388
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6656345f4df9600008e3fc1b

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (9524dd4) to head (cded388).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9433      +/-   ##
==========================================
- Coverage   51.24%   48.61%   -2.64%     
==========================================
  Files         746     1233     +487     
  Lines      110663   158973   +48310     
  Branches     2778     2778              
==========================================
+ Hits        56712    77278   +20566     
- Misses      53777    81521   +27744     
  Partials      174      174              
Flag Coverage Δ
backend 42.16% <ø> (+7.88%) ⬆️
harness 64.02% <ø> (ø)
web 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/aws/cli.py 16.86% <ø> (ø)

... and 488 files with indirect coverage changes

Copy link
Contributor

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just noting that adding the default to the cli arg could have side-effects in terms of not being able to tell if the user has provided it or not which matters at least for some of the other arguments

@tayritenour tayritenour merged commit 00bbda6 into main May 28, 2024
91 of 104 checks passed
@tayritenour tayritenour deleted the fix_shared_fs_mount_default branch May 28, 2024 21:40
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants