-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Admin Settings to NavigationTabbar (ET-194) #9423
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9423 +/- ##
==========================================
- Coverage 48.61% 43.44% -5.18%
==========================================
Files 1233 909 -324
Lines 158972 119056 -39916
Branches 2778 2778
==========================================
- Hits 77278 51718 -25560
+ Misses 81520 67164 -14356
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
ET-194
Description
Adds "Admin Settings" to mobile navigation menu (if user has admin permissions)
Also renames "Settings" option to "User Settings"
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.