test: ensure make unslurmcluster always runs in CI #9420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9420 +/- ##
==========================================
- Coverage 51.24% 45.81% -5.43%
==========================================
Files 746 718 -28
Lines 110663 108876 -1787
Branches 2778 2778
==========================================
- Hits 56713 49886 -6827
- Misses 53776 58816 +5040
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
force-pushed
the
stoksc/ensure-unslurmcluster-always-runs
branch
from
3756b32
to
907a7e7
Compare
|
Added you as a reviewer @dannysauer since I told you I'd do this on a thread yesterday. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9420 +/- ##
==========================================
- Coverage 51.24% 48.61% -2.64%
==========================================
Files 746 1233 +487
Lines 110663 158972 +48309
Branches 2778 2778
==========================================
+ Hits 56713 77283 +20570
- Misses 53776 81515 +27739
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. |
dannysauer
approved these changes
May 24, 2024
|
Yeah, I agree, this probably needs to get added to the terminator script at some point. But this at least fixes the specific issue that caused us to have an explosion of vpcs. |
|
merging over some unrelated failures (known flakes on main) |
stoksc
added a commit
that referenced
this pull request
May 24, 2024
When cluster creation fails halfway, pkill determined-mast will exit with 1. CircleCI runs these inline script with set -e, so that failure causes make unslurmcluster to no run, leaving stray resources behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
When cluster creation fails halfway,
pkill determined-mastwill exit with 1. CircleCI runs these inline script withset -e, so that failure causesmake unslurmclusterto not run and leave stray TF resources behind.Test Plan
Is a test.
Checklist
docs/release-notes/.See Release Note for details.